SPIR-V spec constant tests for separate compilation and linking - #2774
Open
bashbaug wants to merge 13 commits into
Open
SPIR-V spec constant tests for separate compilation and linking#2774bashbaug wants to merge 13 commits into
bashbaug wants to merge 13 commits into
Conversation
Contributor
Author
|
I'll keep this a draft while we determine the exact spec changes, see: KhronosGroup/OpenCL-Docs#553 |
bashbaug
marked this pull request as draft
August 14, 2026 21:28
Contributor
Author
|
Related spec change: KhronosGroup/OpenCL-Docs#1602 |
bashbaug
marked this pull request as ready for review
August 21, 2026 00:02
rjodinchr
reviewed
Aug 21, 2026
fix typo output the build log when compiling a program fails Co-authored-by: Romaric Jodin <rjodin@chromium.org>
rjodinchr
reviewed
Aug 24, 2026
rjodinchr
approved these changes
Aug 24, 2026
svenvh
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests for SPIR-V specialization constants with separate compilation and linking.
These tests check for two conditiona:
This is the new test:
[run-test: test_spirv_new op_spec_constant_compile_link]
These tests were refactored slightly:
[run-test: test_spirv_new op_spec_constant* linkage*]
Also added new tests that set a specialization constant and either build the program object twice or compile the program object twice, ensuring that the updated specialization constant is used for the second compile.
[run-test: test_spirv_new op_spec_constant_build_twice]
[run-test: test_spirv_new op_spec_constant_compile_twice]