error code consistency for memory objects - #1589
Open
bashbaug wants to merge 1 commit into
Open
Conversation
Kerilk
approved these changes
Aug 18, 2026
Contributor
There was a problem hiding this comment.
Looks good to me, a clear improvement. In addition to the CL_EXEC_STATUS_ERROR_FOR_EVENTS_IN_WAIT_LIST discrepancy, I'd note that some call use CL_INVALID_CONTEXT for when events and command queue disagree on context, others (like clEnqueueReleaseExternalMemObjectsKHR) use CL_INVALID_COMMAND_QUEUE, and others like clEnqueueAcquireExternalMemObjectsKHR use neither, so I assume would default to CL_INVALID_EVENT_WAIT_LIST.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is another PR to partially address the way we document error conditions, see #1320 and in particular #1320 (comment).
It contains the remainder of the changes from #1399, so when this PR is merged, #1399 can probably be closed as well.