cube: Recreate suboptimal swapchains - #1245
Open
candux wants to merge 1 commit into
Open
Conversation
A swapchain can become suboptimal without its extent changing. Wayland WSI uses this result when DMA-BUF feedback changes, for example when the compositor starts preferring scanout-capable buffers. Remember a suboptimal acquire until its image has been presented, then try recreating the swapchain. If the replacement remains suboptimal, keep using it instead of recreating every frame. A clean frame re-arms the retry for later surface changes. Tested on KWin. Before this change, vkcube could use direct scanout only after a resize forced swapchain recreation. With this change, it switches to scanout-capable buffers without requiring a resize.
|
Author candux not on autobuild list. Waiting for curator authorization before starting CI build. |
1 similar comment
|
Author candux not on autobuild list. Waiting for curator authorization before starting CI build. |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A swapchain can become suboptimal without its extent changing. Wayland WSI uses this result when DMA-BUF feedback changes, for example when the compositor starts preferring scanout-capable buffers.
Remember a suboptimal acquire until its image has been presented, then try recreating the swapchain. If the replacement remains suboptimal, keep using it instead of recreating every frame. A clean frame re-arms the retry for later surface changes.
Tested on KWin. Before this change, vkcube could use direct scanout only after a resize forced swapchain recreation. With this change, it switches to scanout-capable buffers without requiring a resize.