Closes #60 invalid values for get_int_box on left-top tif border#74
Open
st-korn wants to merge 1 commit into
Open
Closes #60 invalid values for get_int_box on left-top tif border#74st-korn wants to merge 1 commit into
st-korn wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes, when box is over left or over top border of the tif,
i_minorj_minwere negative.It causes zerro-range of array selected.
See issue #60
i_min,j_min: if they are negative - I make them equal to zero.i_max,j_maxof tif dimensions, and if they are greater - I make them equal to tif width or height. This is not necessary. Range is correct selected from array, wher its borders are greater than array's length.i_min,j_minof tif dimensions, and if they are greater - I raiseBoundaryNotInTifError. Because the box is located outside tid file.i_max,j_max: if they are negative - I raiseBoundaryNotInTifError. Because the box is located outside tid file.I remove function
_check_bound_in_tiff. It was called only from withinget_int_box. Nowget_int_boxalready contains all its functionality.I tested code with
mypyand usepre-commitfor verification.