fix(ci): stabilize shared suite failures exposed after checkout fix#12
Closed
KitsuneKode wants to merge 8 commits into
Closed
fix(ci): stabilize shared suite failures exposed after checkout fix#12KitsuneKode wants to merge 8 commits into
KitsuneKode wants to merge 8 commits into
Conversation
…assets GitHub resolves local composite actions from the workspace before any step runs, so nesting checkout inside setup-bun-monorepo made every CI/release/ build-binaries job fail instantly since that action landed. Callers now checkout first; the composite only sets up Bun/caches/install. Also: native smoke matrix for host binaries, fail_on_unmatched_files + asset-count assert on release upload, clearer empty-release installer errors, and fix install.ps1 returning early after mpv so yt-dlp is offered. Co-authored-by: Manash Pratim Bhuyan <bhuyanmanash2002@gmail.com>
v0.2.6.json has an empty sections array (changelog body has no ### headings). The docs test required sections and failed once CI actually ran again after the checkout fix. Co-authored-by: Manash Pratim Bhuyan <bhuyanmanash2002@gmail.com>
These failures only surfaced once CI started executing the full suite again (#8). Fix the durable diagnostics retention time bomb, make install.ps1 dry-run succeed without LOCALAPPDATA/network, stop mock.module leaking from palette tests into history/overlay tests, and gate live Miruro network checks.
Typecheck failed because openSetupWizardFromShell was mocked as Promise<void> instead of Promise<SetupWizardResult>, which also broke Format (turbo depends on typecheck for fmt:check).
…rship Make the deprecated preferred-source unit test mock network instead of live fetch, and harden Videasy so deprecated preferred ids never bias cycle order or probe Sanji/1movies. Document that resolveEscTransition stays unused at runtime because root-overlay-shell + resolveOverlayBackStack already own Esc.
Replace mock.module in watch-genre-stats with a restored spy so later tmdb-proxy/title-detail/recommendation tests see the real module, and use relative timestamps in stats-service so windowed averages stay valid.
This was referenced Jul 9, 2026
4 tasks
Owner
Author
|
Closing as a stale duplicate stack base. Its work is included in #15; any still-relevant deterministic test fixes will be reapplied narrowly on current main. The remote branch is retained. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stabilizes the shared CLI/provider suite that started failing once CI actually ran after the checkout fix (#8).
CI on this tip is green (Format / Lint / Typecheck / Test / builds / installer smoke).
Why CI was red (two layers)
setup-bun-monorepocomposite ran beforeactions/checkout→ every job died in ~3s with missingaction.yml.openSetupWizardFromShellspy returnedPromise<void>instead ofSetupWizardResult(Format fails because turbo runs typecheck beforefmt:check)"completed"from the spyanime-discovery-resolve-handoff.test.tsneeded oxfmt after live-provider gatemock.module("@/services/catalog/tmdb-proxy")inwatch-genre-stats.test.tsleaked into later filesspyOn+mock.restore()avgEpisodesPerDay(and other stats)2026-06-*dates fell outside rolling windowsDate.now()offsetsKUNAI_LIVE_PROVIDERS=1install.ps1dry-runMerge order
Test plan
apps/clisuite green