Security: DOM XSS in server UI from untrusted transcript content#299
Open
tuanaiseo wants to merge 2 commits into
Open
Conversation
The web UI writes `message.text` directly into `innerHTML` for both realtime and full sentence updates. Since this data comes from a WebSocket channel, any attacker-controlled message can inject script/HTML into the page. Affected files: index.html, client.js Signed-off-by: tuanaiseo <221258316+tuanaiseo@users.noreply.github.com>
The web UI writes `message.text` directly into `innerHTML` for both realtime and full sentence updates. Since this data comes from a WebSocket channel, any attacker-controlled message can inject script/HTML into the page. Affected files: index.html, client.js Signed-off-by: tuanaiseo <221258316+tuanaiseo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The web UI writes
message.textdirectly intoinnerHTMLfor both realtime and full sentence updates. Since this data comes from a WebSocket channel, any attacker-controlled message can inject script/HTML into the page.Severity:
highFile:
RealtimeSTT_server/index.htmlSolution
Replace
innerHTMLwrites withtextContentand explicit element creation. For highlighting, split and append safe text nodes/spans instead of string-based HTML templating.Changes
RealtimeSTT_server/index.html(modified)example_browserclient/client.js(modified)Testing