Remove test using calculateFWHM from test_atm_psf_fft #494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vered by a test with calculateMomentRadius, and the result of calculateFWHM is non-deterministic / dependent on NumPy version (currently being fixed in GalSim).
Collaborator
Author
|
Thanks Jim, merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #493 we found an issue with
calculateFWHM()as used in one of the PSF tests. This is now being fixed in GalSim (GalSim-developers/GalSim#1337) but in the meantime @rmjarvis has suggested removing the lines calculating and testing the FWHM in the imSim test as there are already assertions that the size is as expected usingcalculateMomentRadius(). This PR simply removes the references to the FWHM and the assertion.Once this is merged into main, I'll rebase #493 onto it and push again.