Merged
Conversation
… properties - add hardtables to study schema for study design lookup tables (genes, routes, assays, etc.) - use hardtables in existing GWT study designer UI - remove AssayDefinitionDialog and SampleTypeDefinitionDialog - show lookup values from current container plus project - don't show "inactive" lookup values for new study designs
… - Data truncation error
- New fields to existing study tables, include in import/export and insert/edit UI - New study design tables for storing treatment info (provisioned tables) - New misc study tables: objective, personnel, and visittag - Assay schedule: move existing tables/data/UI from rho schema to study
- Vaccine design: immunogens grid UI and add/remove buttons - Vaccine design: HIV antigens sub-grid dialog - Vaccine design: adjuvants grid UI and add/remove buttons - Vaccine Design: make use of project level lookups - Vaccine design: read/write to studydesign tables
Create new study design provisioned domains (personnel, product, treatment) at the project level.
…ng context. For example: - h() instead of PageFlowUtil.filter() - getViewContext() instead of HttpView.currentContext(), HttpView.getRootContext(), me.getViewContext(), et al - getContainer(), getUser(), and getActionURL() instead of me.getViewContext().getContainer(), et al
- Immunization Schedule: treatment definition grid UI - Immunization schedule: immunogen/adjuvant selection dialog - Immunization schedule: read/write to studydesign tables
…utputting context path, etc.
- Immunization schedule: grid UI and add/remove buttons - Immunization schedule: immunogen/adjuvant selection dialog - Immunization Schedule: treatment definition grid UI - Immunization schedule: read/write to studydesign tables
- Immunization schedule: grid UI and add/remove buttons - Immunization schedule: immunogen/adjuvant selection dialog - Immunization Schedule: treatment definition grid UI - Immunization schedule: read/write to studydesign tables
- StudyTreatmentVisitMapTable treatment column FK - StudyController.DeleteStudyProdcutAction - hover display of treatment study products - treatment edit dialog display for product with long label (hack at setting height)
- timepoint definition dialog allow selection of existing study timepoint - allow creating a new study timepoint from the immunization schedule grid
- allow creating a new study timepoint from manage assay schedule visit grid
isDefaultFieldName()
- add description text and move edit button to top
- add Lab and SampleType field to study.AssaySpecimen table - use study design lookups for lab and sample type in table FK and UI combo
- create new TreatmentManager and move several methods out of StudyManger - rename mangeAssaySpecimenAction to manageAssayScheduleAction - don't use JSONObject in StudyDesignController APIAction response
Change to vaccine design webpart display so immunogens and adjuvants are aligned horizontally
Original PR: LabKey/platform#5519
Original PR: LabKey/platform#6147
Original PR: LabKey/platform#6161
Original PR: LabKey/platform#6742 * Minor auto-refactor code cleanup on a massive scale * Fix DomainDesignerTest, reduce usage of deprecated methods * Fix merge
Original PR: LabKey/platform#6911
Original PR: LabKey/platform#6933
labkey-adam
reviewed
Feb 26, 2026
Contributor
labkey-adam
left a comment
labkey-adam
left a comment
There was a problem hiding this comment.
@labkey-tchad why are there 7 commits dating back to May, 2025 in this branch?
labkey-tchad
force-pushed
the
fb_studydesign
branch
from
1acc163 to
4ef8c09
Compare
Member
Author
That is the history of the studydesign module. It should actually be much longer. I just repushed with a more complete history. |
labkey-tchad
force-pushed
the
fb_studydesign
branch
from
4ef8c09 to
d6a3ae2
Compare
Contributor
History. Of course. |
labkey-adam
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
https://github.com/LabKey/internal-issues/issues/883
Related Pull Requests
Changes