GitHub Issue 829: Sample type with lookup to list with text primary key where the value contains a comma doesn't map to lookup#1946
Open
GitHub Issue 829: Sample type with lookup to list with text primary key where the value contains a comma doesn't map to lookup#1946
Conversation
…port multiple values
…port multiple values
labkey-susanh
approved these changes
Feb 27, 2026
Contributor
labkey-susanh
left a comment
labkey-susanh
left a comment
There was a problem hiding this comment.
I have not done any testing, but changes make sense to me.
| col.name, | ||
| values.size === 1 ? quoteValueWithDelimiters(values.first()?.display, ',') : undefined | ||
| ); | ||
| row = row.set(col.name, values.size === 1 ? values.first()?.display : undefined); |
Contributor
There was a problem hiding this comment.
Minor: the ? after first() seems unnecessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
GitHub Issue 829: Sample type with lookup to list with text primary key where the value contains a comma doesn't map to lookup
Related Pull Requests
Changes
quoteValueWithDelimiterson values if the lookup column support multiple values