GitHub Issue 897: Study dataset should not allow multivalue text choice as a third key#1948
Merged
GitHub Issue 897: Study dataset should not allow multivalue text choice as a third key#1948
Conversation
…ce as a third key
cnathe
approved these changes
Mar 6, 2026
Contributor
cnathe
left a comment
cnathe
left a comment
There was a problem hiding this comment.
Approving, but see note about jest test coverage.
|
|
||
| domain.fields | ||
| .filter(field => !field.isCalculatedField()) | ||
| .filter(field => !field.isCalculatedField() && !field.isMultiChoiceField()) |
Contributor
There was a problem hiding this comment.
since this function is more of a util than an action, it seems like it could have some jest test coverage. If you've found a place on the selenium side to easily add this coverage, that works but otherwise jest test coverage here for the filter would be good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
GitHub Issue 897
Related Pull Requests
Changes