Skip to content

GitHub Issue 867: Cannot filter through a file data field #7452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
XingY wants to merge 2 commits into
base: develop
Choose a base branch
from
+5 −2
Open

GitHub Issue 867: Cannot filter through a file data field #7452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c288acd
GitHub Issue 867: Cannot filter through a file data field
XingY Feb 25, 2026
d93ff6f
CRLF
XingY Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions api/src/org/labkey/api/study/assay/FileLinkDisplayColumn.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,12 +466,12 @@ public Object getExportCompatibleValue(RenderContext ctx)
@Override
public boolean isFilterable()
{
return false;
return true;
}
@Override
public boolean isSortable()
{
return false;
return true;
}

}
3 changes: 3 additions & 0 deletions api/webapp/clientapi/ext3/FilterDialog.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,9 @@ LABKEY.FilterDialog = Ext.extend(Ext.Window, {
}

this.allowFacet = false;
if (this.column.inputType === 'file')
return this.allowFacet;
Copy link
Contributor

@labkey-susanh labkey-susanh Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this.column.facetingBehaviorType has the default value of AUTOMATIC. Is there no good way to set it to ALWAYS_OFF? Then we wouldn't have to special case this. Looks like MutableColumnInfoWrapper has a setter method.

Copy link
Contributor Author

@XingY XingY Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I'll look into this approach instead.


switch (this.column.facetingBehaviorType) {

case 'ALWAYS_ON':
Expand Down