Skip to content

Allow assigning "See Audit Log Events" role in folders & projects#7460

Open
labkey-adam wants to merge 4 commits intodevelopfrom
fb_can_see_audit_log
Open

Allow assigning "See Audit Log Events" role in folders & projects#7460
labkey-adam wants to merge 4 commits intodevelopfrom
fb_can_see_audit_log

Conversation

@labkey-adam
Copy link
Contributor

Rationale

We want this role available on a more granular basis. See https://github.com/LabKey/internal-issues/issues/853

Technically, I'm adding a second role with the same name. This allows me to provide a different description at the root (discouraging use of the role there). It's also necessary because the server gets crabby if you try to mix site roles and folder roles in the same role impersonation session.

super("See Audit Log Events", "Allows non-administrators to view audit log events",
super("See Audit Log Events", "Allows non-administrators to view audit log events in the " +
"root, every project, and every folder on this site. This level of visibility is not generally recommended. " +
"For more granular control, assign this role at the project or folder level instead.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wording kinda implies that there is a project-wide role assignment option?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning that logs can contain PHI?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning that logs can contain PHI?

Maybe only if compliance is present? Though I guess PHI is PHI, regardless of what modules you have installed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning that logs can contain PHI?

Maybe only if compliance is present? Though I guess PHI is PHI, regardless of what modules you have installed.

I may go with something a little more generic, like "sensitive or protected information."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wording kinda implies that there is a project-wide role assignment option?

My thinking is that site/app administrators know enough about role assignments to understand what "assigning at the project level" means. But I could also just say folder and leave it at that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants