Skip to content

AI front end code review guidelines and claude skills#1292

Open
labkey-martyp wants to merge 1 commit intodevelopfrom
fb_frontend_code_review_skills
Open

AI front end code review guidelines and claude skills#1292
labkey-martyp wants to merge 1 commit intodevelopfrom
fb_frontend_code_review_skills

Conversation

@labkey-martyp
Copy link
Contributor

@labkey-martyp labkey-martyp commented Feb 23, 2026

Rationale

This is a starting point for frontend ai code review guidelines. There are two code review checklists and claude skills, /code-review-react and /code-review-jest. The claude skills have two modes,

  1. Review only staged changes (changes not committed yet). ex. /code-review-react <directory or file path>
  2. Review full files or directories. ex /code-review-jest --full <directory or file path>
  • See .agents/common.md for review priority and format.
  • See the "Required output" section of the .claude/skills/<skill name>/skill.md for the expected output. Note: If there are more than 10 "suggested" changes (non-urgent), only the first 10 will be shown in each run.
  • See the files in .agents/review-checklists/<react or jest>/*.md for the code review checks.

It is recommended to run the code reviews multiple times until all the feedback is addressed.

These guidelines can be used by other ai agents as well, just point them to the directory.

Changes

  • .agents/review-checklists/jest code review checks
  • .agents/review-checklists/react code review checks
  • .agents/review-checkslists/common.md general code review guidelines
  • .claude/skill/<skill name>/skill.md define the claude skill using these guidelines

Copy link
Contributor

@labkey-jeckels labkey-jeckels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have React or Jest changes handy to test this out, but the overall structure seems reasonable.

Others can better comment on whether these are the right items to highlight, but this might be best evaluated through actual testing.

I can see pulling some of this guidance into more general areas in the future. For example, the rules for code comments should be applicable to any language, not just React/TypeScript/JavaScript.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants