Skip to content

fix: cap transaction page size #1407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
silentgeckoaudit3801 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: cap transaction page size #1407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0ff009c
fix: cap transaction page size
silentgeckoaudit3801 Jul 23, 2026
31b0084
test: cover transaction page size cap
silentgeckoaudit3801 Jul 23, 2026
ddfe83f
Merge branch 'main' into fix-transaction-page-size-cap
ogazboiz Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions backend/src/controllers/__tests__/transactionControllerLimits.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import { describe, expect, it } from '@jest/globals';
import { readFileSync } from 'node:fs';

const source = readFileSync(new URL('../transactionController.ts', import.meta.url), 'utf8');

describe('transactionController pagination limits', () => {
it('caps transaction pages at the intended small maximum', () => {
expect(source).toContain('const MAX_LIMIT = 50;');
expect(source).not.toContain('const MAX_LIMIT = 500;');
expect(source).toContain('return Math.min(parsed, MAX_LIMIT);');
});
});

Check failure on line 12 in backend/src/controllers/__tests__/transactionControllerLimits.test.ts

View workflow job for this annotation

GitHub Actions / backend 

Insert `⏎`
2 changes: 1 addition & 1 deletion backend/src/controllers/transactionController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { AppError } from '../errors/AppError.js';
import { asyncHandler } from '../utils/asyncHandler.js';

const DEFAULT_LIMIT = 20;
const MAX_LIMIT = 500;
const MAX_LIMIT = 50;

function parseLimit(value: unknown): number {
if (typeof value !== 'string') return DEFAULT_LIMIT;
Expand Down
Loading