Fix: log the resolved OFT wrapper address (not the optional param) to avoid undefined in errors#1677
Open
carmen0208 wants to merge 3 commits intoLayerZero-Labs:mainfrom
Open
Fix: log the resolved OFT wrapper address (not the optional param) to avoid undefined in errors#1677carmen0208 wants to merge 3 commits intoLayerZero-Labs:mainfrom
carmen0208 wants to merge 3 commits intoLayerZero-Labs:mainfrom
Conversation
Author
|
@St0rmBr3w Hey Matt, can I get you to review this PR please. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Show misleading error message:
Root cause:
error logs referenced the optional input
oftAddress. When callers didn’t pass it, the log showed OFT: undefined even though we had already resolved the actual wrapper via getOAppAddressByEid(...).Change:
oftWrapperAddress.wrapperAddresstooftWrapperAddressfor clearification.