Skip to content

QoL batch 3#1916

Open
nazreen wants to merge 10 commits intomainfrom
qol-3
Open

QoL batch 3#1916
nazreen wants to merge 10 commits intomainfrom
qol-3

Conversation

@nazreen
Copy link
Contributor

@nazreen nazreen commented Jan 23, 2026

Solana OFT debug script: state that value 0 for confirmations means 'use default'

Closes DEVREL-1238

When running:

npx hardhat lz:oft:solana:debug --eid <eid> --dst-eids <dst-eids>  

Before:

           confirmations: 0                                        

After:

           confirmations: 0 (Use Pathway Defaults)

Solana OFT - updateMetadata script supports Token-2022 Metadata Update

Closes DEVREL-1239

Problem

  • lz:oft:solana:update-metadata only supported Metaplex metadata, not Token-2022.

Solution

  • Auto-detect metadata type: SPL Token → Metaplex; Token-2022 → probe Metaplex first, else Token Extensions.
  • Add updateTokenExtensionsMetadata() with authority validation and rent handling for multisig.

Changes

  • updateMetadata.ts: Auto-detect and support Token-2022 metadata with authority checks and rent top-up.

Example Run

pnpm hardhat lz:oft:solana:update-metadata --eid 40168 --mint <MINT> --name "New Name"

@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2026

🧪 E2E Test Status

E2E tests are non-blocking and validate real blockchain interactions. Failures may occur due to network issues, RPC rate limits, or external service downtime.

Test Runs (Newest First):

  • Run #6713 - Passed - 2026-02-10 16:40 (UTC)
  • Run #6709 - Passed - 2026-02-10 02:40 (UTC)
  • Run #6673 - Passed - 2026-02-03 17:18 (UTC)
  • Run #6661 - Passed - 2026-01-29 16:57 (UTC)
  • Run #6628 - Passed - 2026-01-23 22:05 (UTC)

@nazreen nazreen requested review from fabianhug and lzJxhn January 29, 2026 17:09
@nazreen nazreen marked this pull request as ready for review January 29, 2026 17:09
@cursor
Copy link

cursor bot commented Jan 29, 2026

PR Summary

Medium Risk
Adds new Solana transaction-building logic for Token-2022 metadata updates (authority checks, rent transfers, multisig flow), which could affect on-chain update behavior if incorrect; other changes are small QoL improvements.

Overview
Improves Solana OFT task UX and expands metadata update support.

lz:oft:solana:update-metadata now auto-detects whether a mint uses Metaplex metadata or Token-2022 Token Extensions metadata, and adds a Token Extensions update path that validates update authority and optionally tops up rent (including multisig/vault flows by emitting base58 tx data for Squads).

lz:oft:solana:debug now labels confirmations: 0 as "0 (Use Pathway Defaults)", and getOftStoreAddress no longer emits a warning when the deployment file is simply missing (returns null silently, warning only on malformed content).

Written by Cursor Bugbot for commit cbc787d. This will update automatically on new commits. Configure here.

@nazreen
Copy link
Contributor Author

nazreen commented Feb 3, 2026

bump @lzJxhn

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants