Skip to content

fix github protocol drop#5

Open
compermisos wants to merge 2 commits into
Lekensteyn:masterfrom
compermisos:patch-1
Open

fix github protocol drop#5
compermisos wants to merge 2 commits into
Lekensteyn:masterfrom
compermisos:patch-1

Conversation

@compermisos
Copy link
Copy Markdown

lease see https://github.blog/2021-09-01-improving-git-protocol-security-github/

from 11 of january, github drop git:// protocol for un-autenticated users (most automated installs off the lib)

@Lekensteyn
Copy link
Copy Markdown
Owner

Hi, thank you for your PR. It appears that since LuaRocks 3.8, git://github.com URLs are automatically converted: luarocks/luarocks@9ff512e, so there is not an immediate need for a fix.

Did this change work for you? I would expect it to fail, shouldn't the scheme be git+https instead of https? From https://github.com/luarocks/luarocks/wiki/Rockspec-format#user-content-build_rules:

git:// - for the Git source control manager
git+http:// - for the Git source control manager when using repositories that need http:// URLs
https:// - for HTTPS URLs

Aside from that there are some typos in the commit message.

@compermisos
Copy link
Copy Markdown
Author

sorry by the typos
in single test, the change run in luarocks 2.4.8
the packaged version in diferents linux distro, is minor of 2.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants