-
Notifications
You must be signed in to change notification settings - Fork 31
Add initial mypy configuration and CI integration #1655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Add initial mypy configuration and CI integration #1655
Conversation
Introduce mypy with a permissive, incremental configuration. Type checking is limited to libensemble/utils and excludes files not yet migrated. Make libensemble/utils/misc.py compliant with mypy.
Introduce mypy with a permissive, incremental configuration. Type checking is limited to libensemble/utils and excludes files not yet migrated. Make libensemble/utils/misc.py compliant with mypy.
… testing/mypy-initial-setup # Conflicts: # pyproject.toml
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1655 +/- ##
========================================
Coverage 78.29% 78.29%
========================================
Files 76 76
Lines 7580 7580
Branches 1119 1119
========================================
Hits 5935 5935
Misses 1460 1460
Partials 185 185 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi maintainers, when you have time, I’d appreciate any feedback on this PR. |
|
Hello, Thank you for the mypy implementation and fixes. The configuration and CI implementation look good. However, I'm surprised changes to |
Thanks a lot for the quick review. |
Description
This PR adds mypy type checking to libEnsemble using an intentionally permissive initial configuration.
It establishes a baseline that can be tightened incrementally without impacting CI stability.
Related issue: #1633
Changes
CI Impact