Add VS Code Extension Marketplace domains to firewall #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added marketplace.visualstudio.com for main marketplace API - Added gallery.vsassets.io and gallerycdn.vsassets.io for extension downloads - Added vscode.blob.core.windows.net for additional storage - Updated documentation in README.md and CLAUDE.md to reflect all allowed domains This enables VS Code extension installation within the secure devcontainer environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Firewall Script
Added the following domains to
BUILTIN_DOMAINSininit-firewall.sh:marketplace.visualstudio.com- Main marketplace APIgallery.vsassets.io- Extension asset downloadsgallerycdn.vsassets.io- CDN for extension assetsvscode.blob.core.windows.net- Additional storage endpointDocumentation
Why
VS Code extensions couldn't be installed in the devcontainer due to network isolation blocking access to the marketplace servers. This change allows developers to install extensions from within the container while maintaining security.
Testing
After this PR is merged and the image is rebuilt: