Enable multi-architecture Docker builds #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add platforms specification to Docker build-push-action to build for both linux/amd64 and linux/arm64 architectures. This allows the devcontainer to run natively on Apple Silicon Macs without Rosetta emulation.
- Remove automatic service account creation from setup-1password.sh - Update script to only verify authentication status and provide manual instructions - Improve documentation in .env.example with clear step-by-step instructions - Update README with detailed service account creation guide - Focus on manual token configuration for better security and predictability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Multi-architecture Build Support
platforms: linux/amd64,linux/arm64to the Docker build-push-action1Password Setup Simplification
setup-1password.sh.env.examplewith step-by-step guide for creating service accountsImpact
Testing
The multi-architecture build will be tested when this PR triggers the GitHub Actions workflow.