Skip to content

fix: tweak layout for better vertical spacing #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zelkibuilds wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: tweak layout for better vertical spacing #360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/components/Aggregator/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,8 +150,6 @@ const Body = styled.div`

const Wrapper = styled.div`
width: 100%;
height: 100%;
min-height: 100%;
text-align: center;
display: flex;
flex-direction: column;
Expand Down Expand Up @@ -974,7 +972,7 @@ export function AggregatorContainer() {
signatureForSwapMutation.reset();
},
onError: (err: { reason: string; code: string }, variables) => {
console.log(err)
console.log(err);
if (err.code !== 'ACTION_REJECTED' || err.code.toString() === '-32603') {
toast(formatErrorToast(err, false));

Expand Down Expand Up @@ -1051,7 +1049,7 @@ export function AggregatorContainer() {
approvalData: gaslessApprovalMutation?.data ?? {},
eip5792: isEip5792 ? { shouldRemoveApproval: shouldRemoveApproval ? true : false, isTokenApproved } : null,
signature: signatureForSwapMutation?.data,
isSmartContractWallet: (bytecode && bytecode !== '0x') ? true : false
isSmartContractWallet: bytecode && bytecode !== '0x' ? true : false
});
}
};
Expand Down
18 changes: 10 additions & 8 deletions src/components/FAQs/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@ import { Accordion, AccordionButton, AccordionIcon, AccordionItem, AccordionPane
export default function FaqWrapper() {
return (
<>
<Text fontWeight={500} color={'#FAFAFA'} fontSize={24}>
<Text fontWeight={500} color={'#FAFAFA'} fontSize={24} style={{ marginTop: 'auto' }}>
FAQ
</Text>
<Accordion allowMultiple margin={'0 auto'} style={{ width: '100%', maxWidth: '600px' }}>
<Accordion allowMultiple margin={'0 auto'} style={{ width: '100%', maxWidth: '600px', marginBottom: 'auto' }}>
<AccordionItem>
<h2>
<AccordionButton>
Expand Down Expand Up @@ -68,12 +68,14 @@ export default function FaqWrapper() {
</AccordionButton>
</h2>
<AccordionPanel pb={4}>
We inflate gas limit of txs on MetaMask by +40% to ensure that there's nothing unexpected that could trigger out-of-gas reverts. This stacks
on top of any increase your RPC might apply on gas estimations, along with possible different gas prices between your metamask and our estimation.
We inflate gas limit of txs on MetaMask by +40% to ensure that there's nothing unexpected that could trigger
out-of-gas reverts. This stacks on top of any increase your RPC might apply on gas estimations, along with
possible different gas prices between your metamask and our estimation.
<br />
<br />
All this together means that gas number you see on metamask will always be inflated, while in our UI we display the actual gas that the tx will consume.
The extra gas that is not used is just refunded to the user when tx executes.
All this together means that gas number you see on metamask will always be inflated, while in our UI we
display the actual gas that the tx will consume. The extra gas that is not used is just refunded to the user
when tx executes.
</AccordionPanel>
</AccordionItem>
<AccordionItem>
Expand Down Expand Up @@ -104,8 +106,8 @@ export default function FaqWrapper() {
</AccordionButton>
</h2>
<AccordionPanel pb={4}>
Some ETH orders on CoW Swap might not get filled because price moves against you too quickly,
in those cases the ETH just sits in a contract until it is refunded 30 minutes after your tx.
Some ETH orders on CoW Swap might not get filled because price moves against you too quickly, in those cases
the ETH just sits in a contract until it is refunded 30 minutes after your tx.
</AccordionPanel>
</AccordionItem>
</Accordion>
Expand Down
Loading