Skip to content

Update the nCine addons submodule #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
carsakiller wants to merge 1 commit into from
Closed

Update the nCine addons submodule #197

carsakiller wants to merge 1 commit into from

Conversation

@carsakiller
Copy link
Collaborator

@carsakiller carsakiller commented Dec 3, 2024

Fixes the missing trailing comma

@carsakiller carsakiller added the Addon Update An update for an existing addon label Dec 3, 2024
@carsakiller
Copy link
Collaborator Author

carsakiller commented Dec 3, 2024

I believe the workflow is fixed now, but the PR has to be opened by @encelo in order for the permissions to actually work properly, as it is not my fork. @encelo, can you please open a new PR for this? Sorry for the hassle.

Really wish GitHub had a better way to develop and test workflows

@carsakiller carsakiller closed this Dec 3, 2024
@encelo
Copy link
Contributor

encelo commented Dec 3, 2024

I have opened PR #198 but it seems to be still failing. 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Addon Update An update for an existing addon

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@carsakiller @encelo