Skip to content

Conversation

@pcfreak30
Copy link
Member

@pcfreak30 pcfreak30 commented Jan 4, 2026

This refactoring removes the re-export of various utility functions and types from the @lumeweb/query-builder library within libs/portal-sdk/src/query-utils.ts.

Previously, query-utils.ts acted as an intermediary, re-exporting functions such as createEqFilter, createInFilter, createDescSort, and calculatePagination, along with several types, from @lumeweb/query-builder.

With this change:

  • Consumers of these query-builder utilities (including internal test files) will now import them directly from @lumeweb/query-builder.
  • The libs/portal-sdk/src/query-utils.ts module is streamlined to primarily focus on its core function, buildOperationsQueryParams, which internally utilizes serializeQueryParams from @lumeweb/query-builder.

@changeset-bot
Copy link

changeset-bot bot commented Jan 4, 2026

⚠️ No Changeset found

Latest commit: a6e664b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kody-ai
Copy link

kody-ai bot commented Jan 4, 2026

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration
Interacting with Kody
  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Validate Business Logic: Ask Kody to validate your code against business rules by adding a comment with the @kody -v business-logic command.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Bug
Performance
Security
Breaking Changes
Cross File
Kody Rules
Code Style
Refactoring
Error Handling
Maintainability
Potential Issues
Documentation And Comments
Performance And Optimization

Access your configuration settings here.

@pcfreak30 pcfreak30 merged commit 0ee3904 into develop Jan 4, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants