fix: address review feedback for PR #3778#3864
fix: address review feedback for PR #3778#3864adrianschmidt-bot wants to merge 2 commits intoLundalogik:autocomplete-iconsfrom
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| * | ||
| * @public | ||
| */ | ||
| // biome-ignore lint/suspicious/noEmptyInterface: Intentionally empty for module augmentation |
There was a problem hiding this comment.
I just disabled Biome in CodeRabbit, so once the PR is rebased on main, this comment will no longer be needed.
(Do not rebase this branch on main please, let Johan rebase his PR branch, then rebase this on his branch.)
There was a problem hiding this comment.
Got it! I'll leave the biome-suppress comment for now and wait for Johan to rebase his PR branch first, then rebase this one on his.
There was a problem hiding this comment.
@adrianschmidt-bot I have rebased my PR branch!
There was a problem hiding this comment.
I'm not quite sure what happened, the bot ran some tools but then nothing.
@adrianschmidt-bot Since this PR is based on Johan's PR #3778, you'll have to rebase this on the latest from Johan's PR branch. You should also check that the changes you've made in this PR are still relevant for Johan's PR, now that he's made updates to it.
There was a problem hiding this comment.
I thought he decided to just take the day off 😅
There was a problem hiding this comment.
Done! I've rebased onto Johan's latest autocomplete-icons branch.
What changed: Johan's updated commit already incorporates the two fixup commits I had (the string → IconName changes across type files and components). Those are no longer needed.
What's still relevant: The fix: address review feedback commit, which covers three things Johan's commit doesn't:
biome-ignorecomment on the intentionally emptyIconNameRegistryinterface- Relative import path fix in
file.types.ts(./icon.typesinstead of../../global/shared-types/icon.types) IconNametype on private helper signatures ininput-field.tsx(renderLinkIconandrenderTrailingIcon)
The PR is now a single commit on top of Johan's latest.
There was a problem hiding this comment.
Ja, that explains the hiccup earlier — the service was struggling. Should be all good now though, the rebase is done and the PR is ready for review! 🐙
jgroth
force-pushed
the
autocomplete-icons
branch
from
c588dc0 to
006553d
Compare
jgroth
force-pushed
the
autocomplete-icons
branch
from
006553d to
fdcc416
Compare
- Add biome-ignore for intentionally empty IconNameRegistry interface - Use relative import path in file.types.ts (same directory) - Update private helper signatures in input-field.tsx to use IconName
adrianschmidt-bot
force-pushed
the
fix/pr-3778-review-feedback
branch
from
bfec93c to
2f7da7e
Compare
|
Documentation has been published to https://lundalogik.github.io/lime-elements/versions/PR-3864/ |
jgroth
force-pushed
the
autocomplete-icons
branch
from
fdcc416 to
b5d7433
Compare
3 participants
Addresses review feedback from #3778:
biome-ignorecomment for the intentionally emptyIconNameRegistryinterface (used for module augmentation)file.types.tsto use relative./icon.typesimport (same directory)renderLinkIconandrenderTrailingIconprivate helper signatures ininput-field.tsxto useIconNameinstead ofstring@jgroth Feel free to pull this in if it looks good! 🙂