Skip to content

feat(soroban): detect cross-contract calls inside loops - #908

Merged
mijinummi merged 1 commit into
MDTechLabs:mainfrom
adeniran19-maker:feat/876-detect-cross-contract-calls-in-loops
Aug 29, 2026
Merged

feat(soroban): detect cross-contract calls inside loops#908
mijinummi merged 1 commit into
MDTechLabs:mainfrom
adeniran19-maker:feat/876-detect-cross-contract-calls-in-loops

Conversation

@adeniran19-maker

Copy link
Copy Markdown
Contributor

Closes #876

Summary of Changes

  • Loop Cross-Contract Call Analyzer: Implemented packages/analyzers/soroban/calls/cross-contract-calls-in-loop-analyzer.ts to detect repeated external contract calls executed within loops.
  • Loop Bound & Context Analysis:
    • classifyLoopHeader: Evaluates loop types (for, while, loop) and bounds (bounded_range, collection_iterator, unbounded, dynamic_condition).
    • Estimates cost multipliers and flags severity accordingly (critical for unbounded loops, high for dynamic iterations).
  • Rule Definition & Integration:
    • Implemented packages/rules/soroban/src/calls/cross-contract-calls-in-loop-rule.ts (soroban-cross-contract-calls-in-loop).
    • Exported through packages/rules/soroban/src/calls/index.ts.
  • Test Suite: Added unit test coverage in packages/rules/soroban/tests/cross-contract-calls-in-loop.spec.ts.

Verification

  • Ran ./node_modules/.bin/jest packages/rules/soroban/tests/cross-contract-calls-in-loop.spec.ts (4/4 passing).

@drips-wave

drips-wave Bot commented Aug 29, 2026

Copy link
Copy Markdown

@adeniran19-maker Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@mijinummi
mijinummi merged commit 0021b40 into MDTechLabs:main Aug 29, 2026
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Detect Cross-Contract Calls Inside Soroban Loops

2 participants