Check for transport output before loading input files#1128
Merged
xylar merged 1 commit intoMPAS-Dev:developfrom Dec 5, 2025
Merged
Conversation
Collaborator
Author
|
In testing E3SM-Project/zppy#760, we find that one additional change is needed to ensure transport time series can be generated from the cache. |
Collaborator
|
The Python 3.14 fail is expected, see #1127 (comment). Since I expect a fix in not too long, we could just disable python 3.14 in CI now and re-enable it in #1127. But I would prefer not to bother. |
Collaborator
|
I changed my mind. I'll drop it for now in #1129 |
d38a60d to
236c5fa
Compare
Collaborator
TestingI ran the dev suite with thing branch and things work fine (the |
Collaborator
|
I realize I should have approved this formally. The changes are simple and make sense. |
Collaborator
Author
|
@xylar Thank you for reviewing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check for transport output before loading input files