Update the core_atmosphere cmake file to include src/framework#1366
Merged
mgduda merged 1 commit intoMPAS-Dev:developfrom Oct 22, 2025
Merged
Update the core_atmosphere cmake file to include src/framework#1366mgduda merged 1 commit intoMPAS-Dev:developfrom
mgduda merged 1 commit intoMPAS-Dev:developfrom
Conversation
amstokely
suggested changes
Oct 6, 2025
Contributor
amstokely
left a comment
There was a problem hiding this comment.
Consider adding the following to the framework CMakeLists.txt:
target_include_directories(framework
INTERFACE
${CMAKE_CURRENT_SOURCE_DIR}
)
This will automatically append the framework source directory to the core_atmosphere include path, achieving the same result without relying on relative paths.
Contributor
Author
Putting the dependency in the framework cmake file sounds much cleaner. I'll make an update. |
31d783d to
8f138e6
Compare
Contributor
Author
|
The src/framework directory is now exported by the framework CMakeLists.txt, as suggested by @amstokely. |
abishekg7
approved these changes
Oct 7, 2025
Collaborator
abishekg7
left a comment
There was a problem hiding this comment.
Looks good to me. Checked that it builds correctly.
amstokely
approved these changes
Oct 16, 2025
…Make In PR 1359 a new file, src/framework/mpas_halo_interface.inc is included by several files in the src/core_atmosphere tree. Therefore compiling core_atmosphere now requires including src/framework. To accomplish that the CMakeLists.txt file for src/framework now exports its source directory as an interface include directory. This adds that directory to the compilation include path for any target which links against framework.
8f138e6 to
42b5d79
Compare
mgduda
approved these changes
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds an include of the src /framework directory when building core-atmosphere.
This is required due to a dependency added in #1359.
This fix was tested by building MPAS-Model core_atmosphere via cmake, using the gnu compiler.
This was also tested by building the mpas-bundle suite via cmake using the gnu compiler.