Create Uummannaq/Disko Bay geometric_features#256
Create Uummannaq/Disko Bay geometric_features#256alexolinhager wants to merge 1 commit intoMPAS-Dev:mainfrom
Conversation
alexolinhager
force-pushed
the
UummannaqDisko_regions
branch
3 times, most recently
from
30fbfe7 to
9c18fd5
Compare
ntroduces a geometric_features collection of all GIS tidewater outlet glaciers in the Uummannaq/Disko Bay region of Greenland.
alexolinhager
force-pushed
the
UummannaqDisko_regions
branch
from
9c18fd5 to
b5b0dd4
Compare
| The function :py:func:`geometric_features.aggregation.landice.uummannaq_disko` | ||
| aggregates the GIS tidewater outlet glaciers flowing into the Ummannaq and Disko Bay region of | ||
| Greenland. Glacier boundaries were defined using the ice basin layer in QGreenland | ||
| (https://github.com/nsidc/qgreenland/) and manually manipulated near the glacier termini to create |
There was a problem hiding this comment.
Can you add a version tag here in case these basin definitions change in future QGreenland releases?
| Greenland. Glacier boundaries were defined using the ice basin layer in QGreenland | ||
| (https://github.com/nsidc/qgreenland/) and manually manipulated near the glacier termini to create | ||
| a buffer zone around each outlet glacier, so that QGreenland boundaries encompass the full glacier area | ||
| defined on the MALI mesh. |
| Parameters | ||
| ---------- | ||
| gf : geometric_features.GeometricFeatures | ||
| An object that knows how to download and read geometric features |
There was a problem hiding this comment.
The wording "knows how to" is strange to me.
There was a problem hiding this comment.
Nevermind, now I see that this is taken from other places in the code base.
@trhille, take a look at: You should create a compass development environment as usual, then install |
|
@alexolinhager, it seems like maybe you're doing your development without having It seems right now like you have some trailing whitespace. |
TestingI tested this using https://github.com/alexolinhager/compass/tree/create_uummannaq_disko at commit f185877 rebased onto |
3 participants
Introduces a geometric_features collection of all GIS tidewater outlet glaciers in the Uummannaq/Disko Bay region of Greenland.