Send events through NativeEventEmitter rather than the bridge on iOS.#46
Conversation
…ance (fix for RN ~0.45+)
|
Thank you @ashemah Reviewing was straight forward, nice job!
|
|
Hi Erwan, can you confirm that it is working properly? I am having issues
with it still and don't want you to push something broken.
I think the issue was that the code is now using the 'next' versions of the
JS platform specific libraries when I thought it was using the old versions.
I am still looking into it but please don't push it to NPM if you are
seeing an issue as well.
…On Fri, 22 Sep 2017 at 14:48 Erwan DATIN ***@***.***> wrote:
Thank you @ashemah <https://github.com/ashemah>
Reviewing was straight forward, nice job!
- I will have to update documentation and example samples to reflect
this new version.
- push it to npm (within this day)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#46 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAcKss9VgSDnjBZTJ4lNkHnUckdJMOACks5skzwBgaJpZM4PgG9w>
.
|
|
I will fix it soon. Right now I can't dedicate time. |
|
@ashemah you did a good job 👍 I fixed BeaconsDemo project. DeviceEventEmitter.addListener()
// simply becomes (for android and iOS)
Beacons.BeaconsEventEmitter.addListener()I have now another really interesting PR( #45 from @stoneman1) to review and merge (for android this time). So it stays in master and maybe I may create a |
|
You know... now that the event emitter is on the |
|
Yes @dlindahl . This is now I just wonder what use case apart from simulating you ranged a beacon or left a region after a timeout? I would be pleased to read your suggestions |
This is based off the latest RN native modules docs.
I have also updated the ranging.ios.js example.
Note: I am getting an error when running this:
this._nativeModule.addListener is not a function.
I have no idea where this is coming from exactly.