fix(sidebar): surface Settings + Sign out for guests#3
Merged
Conversation
The sidebar footer's Settings gear and account dropdown lived inside
{#if authStore.isLoggedIn}, which excludes guests by design — so guests
literally couldn't open Settings even though their localStorage-backed
API keys live there. The "Guest User" branch only rendered a sign-in
button.
Mirror the signed-in dropdown shape for guests:
- Settings (gear icon + dropdown item)
- Sign in (the existing primary affordance)
- Sign out (only when authStore.isGuest is true — a guest with an
active graphini_guest_id cookie can clear it; a true logged-out
state with no guest cookie has nothing to sign out of)
Avatar uses a UserCircle placeholder. The dropdown header reads
"Guest User / Sign in to save your work" so the secondary CTA is
discoverable without burying the primary action.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Guests couldn't open Settings — the gear icon and account dropdown were inside
{#if authStore.isLoggedIn}(which excludes guests by design), so the only thing a guest saw in the footer was a "Sign in" button. Their localStorage-backed API keys live in Settings, so this made the local-keys design unusable for guests.Mirror the signed-in dropdown shape for guests:
authStore.isGuestis true (an active guest with agraphini_guest_idcookie). True logged-out state with no cookie has nothing to sign out of.Header reads "Guest User / Sign in to save your work" so the secondary CTA is discoverable without burying the primary action.
Test plan