feat(audio): implement volume change audio notifications#558
Draft
romanstingler wants to merge 1 commit intoMalpenZibo:mainfrom
Draft
feat(audio): implement volume change audio notifications#558romanstingler wants to merge 1 commit intoMalpenZibo:mainfrom
romanstingler wants to merge 1 commit intoMalpenZibo:mainfrom
Conversation
85ef1f8 to
f3fe0aa
Compare
f3fe0aa to
f9448df
Compare
Owner
|
I was thinking that now that we were able to reduce the number of dependencies we could evaluate to use rodio. We should probably need to add some dependency in the package and nix config to be able to compile. So we could proceed by step. If this solution is acceptable let's merge and see, then if it's used and adding rodio is not a pain in the ass we can proceed adding a "real" audio support |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the discussion in #525
and taking into consideration @MalpenZibo concerns and also his POV to keep external dependencies to a minimum,
I thought we could provide this feature as an opt-in and who wants to use it, can do it but has some prerequisites.
Required packages:
pipewire+sound-theme-freedesktop(If you want to use the default sound)I added the option to add this to the config
For now I wanted to have your feedback on this idea.
I added a audio feedback mechanism that triggers beep sounds during volume adjustments through sliders, scroll and mute toggle.
It utilizes
pw-catfor playback with built-in rate-limiting(I had some issues with throttling that external command, so that it doesn't overlap too much, so I tried to track the PID and not dispatch a next one too early, but this is still a WIP ).
For now I just took
/usr/share/sounds/freedesktop/stereo/bell.ogaas a fallback (should be the Gnome/Cosmic one if I am not mistaken).For now I am checking if the executable
pw-catis present and also if the configured path foraudio_feedback_sound = "/usr/share/sounds/freedesktop/stereo/bell.oga"is valid.
There are a few known issues like. beep on mic mute (this is because the audio volume is still not 0). I don't know where to put the default path, for now I just kept the audio stuff together.
But I wanted your feedback before I do any further stuff,
closes #525