Feat/replace style with margin padding background#614
Draft
MalpenZibo wants to merge 5 commits intomainfrom
Draft
Feat/replace style with margin padding background#614MalpenZibo wants to merge 5 commits intomainfrom
MalpenZibo wants to merge 5 commits intomainfrom
Conversation
…options Remove the AppearanceStyle enum (Islands/Solid/Gradient) and replace it with three independent config options: margin (outside bar margin via Wayland layer-shell), padding (internal content padding), and background (None, Palette, custom hex color, or gradient). Module backgrounds are derived from the bar background — transparent bar gets individual rounded module containers (islands look), otherwise modules have no background.
Remove the gradient variant from BarBackground and related types (GradientSpec, GradientPalette). The gradient needs more design work to be visually effective. Background now supports: None, Palette, or a custom hex color.
…mically Remove the const HEIGHT = 34 and the gradient background option. Bar height is now computed from font_size.xl + module padding + configured bar padding, so it automatically adapts when padding changes. The exclusive zone and surface size are derived from this computed height.
Add From<&AppearanceColor> for Color and a hex_to_color helper function to replace get_base(). Rename get_text() to text(), get_weak_pair() to weak_pair(), get_strong_pair() to strong_pair() for idiomatic Rust naming. Addresses review feedback from PR #574.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #615
Dropping gradient style support?
it's used by someone?