Skip to content

test(entrypoint): cover the python -m CLI help path - #147

Open
MohamedAli1937 wants to merge 2 commits into
MarcoPorcellato:mainfrom
MohamedAli1937:test/add-module-entrypoint-tests
Open

test(entrypoint): cover the python -m CLI help path#147
MohamedAli1937 wants to merge 2 commits into
MarcoPorcellato:mainfrom
MohamedAli1937:test/add-module-entrypoint-tests

Conversation

@MohamedAli1937

Copy link
Copy Markdown
Contributor

Description

Fixes #130

Adds tests/test_module_entrypoint.py to verify that executing python -m logseq_matryca_parser --help exits cleanly with code 0 and exposes the core matryca-parse CLI surface and subcommands without requiring a user vault.

Type of change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update

🛡️ Sovereign Developer Checklist

  • I have read CONTRIBUTING.md (or picked a task from docs/GOOD_FIRST_ISSUES.md).
  • I have executed make all locally, and all linters (Ruff), type-checkers (Mypy), and tests (Pytest) pass successfully.
  • I have added/updated tests for my changes (if applicable).
  • I have updated the relevant documentation (README.md, docs/, CONTRIBUTING.md as needed).
  • I updated CHANGELOG.md under [Unreleased] for user-visible behavior changes.
  • My code follows the project's typing conventions (explicit hints on new functions; Pydantic strict=True on domain models).

Screenshots / CLI Output (if applicable)

Screenshot 2026-08-10 123004

Copilot AI lite review requested due to automatic review settings August 11, 2026 10:34

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@MarcoPorcellato MarcoPorcellato left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MohamedAli1937, thanks for the focused entrypoint test.

One small change is needed before merge: please run the subprocess from tmp_path (for example, cwd=tmp_path). The issue requires the module entrypoint to work independently of the repository working directory, and the current test inherits pytest’s CWD.

Please also add a short timeout to the subprocess, then run make all and push the resulting CI run. Thanks!

@MohamedAli1937

Copy link
Copy Markdown
Contributor Author

Done — I rebased onto the latest main, updated the test to use tmp_path and a 10-second timeout, and pushed the changes. CI is running now.

@MarcoPorcellato

Copy link
Copy Markdown
Owner

Hi @MohamedAli1937, the checks are green, but GitHub reports conflicts only in generated metrics files. Please rebase on the latest main, keep the current main versions of the metrics files, and keep this PR limited to tests/test_module_entrypoint.py. Then push again. Thanks!

@MohamedAli1937
MohamedAli1937 force-pushed the test/add-module-entrypoint-tests branch from a49ec18 to 5d3452d Compare August 18, 2026 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(entrypoint): cover the python -m CLI help path

3 participants