MDBF-1158: Implement MTR stdout log parsing #895
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RazvanLiviuVarzaru
force-pushed
the
stdout-collect
branch
from
38ed801 to
00d0090
Compare
Collaborator
|
Looks good. It's better to compare integer in bash with |
Related: MariaDB/mtr-log-collector#1 This patch can be merged without waiting for MariaDB/mtr-log-collector#1 . Clients will continue to use .xml files, ensuring backward compatibility. A separate patch will update the clients to use `stdout.log` files. Changes: - Update mtr_reporter.sh to handle log files - Introduce a dry-run option for local testing - Make the service name more generic: `MTR_LOG_COLLECTOR_BASE_URL` - Update `MTRReporter` to handle both XML and log formats; XML remains the default to avoid breaking existing clients
RazvanLiviuVarzaru
force-pushed
the
stdout-collect
branch
from
00d0090 to
81b28ef
Compare
Collaborator
Author
Thank you @fauust for the review, fixed the comparison. Also let me know if you want to review: MariaDB/mtr-log-collector#1 |
fauust
approved these changes
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: MariaDB/mtr-log-collector#1
This patch can be merged without waiting for MariaDB/mtr-log-collector#1 . Clients will continue to use .xml files, ensuring backward compatibility.
A separate patch will update the clients to use
stdout.logfiles.Changes:
MTR_LOG_COLLECTOR_BASE_URLMTRReporterto handle both XML and log formats; XML remains the default to avoid breaking existing clients