Wisp param resilience, subagent max_iterations, and shared volume fixes#274
Merged
rockfordlhotka merged 1 commit intomainfrom Apr 15, 2026
Merged
Conversation
…olume fixes Wisps failed consistently because LLMs put MCP tool arguments in the wrong JSON field (input, arguments, input_from instead of params). Rather than chasing each alias, WispStep.ResolvedParams now checks all plausible fields including rescuing JSON objects from input_from. MCP gateway rejects steps with no params at all with an actionable error message. Subagents hitting the 25-iteration cap on large tasks can now be spawned with max_iterations to override the model default. The override flows through an AsyncLocal context so the singleton FunctionInvokingChatClient picks it up per-request. Files written to the shared volume by wisps and file_write are now world-writable (666) so script containers and MCP servers running as different users can overwrite them. Script tool guide strengthened to emphasize absolute paths via ROCKBOT_SHARED_PATH. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
input,arguments,input_frominstead ofparams).WispStep.ResolvedParamsnow checks all plausible fields and rescues JSON objects frominput_from. MCP gateway rejects steps with no params with an actionable error message.max_iterationsoverride: Primary agent can now passmax_iterationstospawn_subagentto elevate the iteration cap for heavy tasks. Flows throughAsyncLocalso the singletonFunctionInvokingChatClientpicks it up per-request.file_writeare now666so script containers and MCP servers running as different users can overwrite them.ROCKBOT_SHARED_PATHand call out the wispoutput_to→ script relative path trap.spawn_wispsfor repetitive parallel work.Test plan
input/arguments/input_fromaliases (deserialization + gateway routing)max_iterationsparsing inSpawnSubagentExecutorparamsfield🤖 Generated with Claude Code