release helm chart github action#2917
Open
zlosim wants to merge 2 commits intoMarquezProject:mainfrom
Open
Conversation
Signed-off-by: Michal Vince <vince.michal@gmail.com>
Signed-off-by: Michal Vince <vince.michal@gmail.com>
|
Thanks for opening your first pull request in the Marquez project! Please check out our contributing guidelines (https://github.com/MarquezProject/marquez/blob/main/CONTRIBUTING.md). |
✅ Deploy Preview for peppy-sprite-186812 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2917 +/- ##
=========================================
Coverage 83.10% 83.10%
Complexity 1487 1487
=========================================
Files 264 264
Lines 6849 6849
Branches 315 315
=========================================
Hits 5692 5692
Misses 1002 1002
Partials 155 155 ☔ View full report in Codecov by Sentry. |
Member
|
@wslulciuc hi, any update on this? This is great feature and we'd like to have a helm repo! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
there is no official helm chart repo
Closes: #1695
Solution
added github action and modified chart folder structure so it follows best practices
you need to create empty gh-pages branch
One-line summary:
added gh action for releasing helm chart to gh pages
Checklist
CHANGELOG.md(Depending on the change, this may not be necessary)..sqldatabase schema migration according to Flyway's naming convention (if relevant)