Fix strpos argument order and add tests
#34907
Open
+35
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
strposfollows PostgreSQL argument order(string, substring)instead of the reversed order used previously.strposbehaves consistently withposition.Description
Strposvariant to theBinaryFuncenum and wire it into the binary function dispatch and related trait methods (eval,output_type,propagates_nulls,introduces_nulls,is_infix_op,negate,could_error,is_monotone, andfmt).strpos(string: &str, substring: &str)that delegates to the existingpositionimplementation with the arguments swapped (position(substring, string)).strpostoBinaryFunc::from(func::Strpos)inPG_CATALOG_BUILTINSand add sqllogictest entries intest/sqllogictest/string.sltcoveringstrposbehavior and examples.Testing
test/sqllogictest/string.sltexercisingSELECT strpos(strcol2, strcol1)andSELECT strpos('high', 'ig'), but no automated test suite was executed in this change.Codex Task