Skip to content

feature-benchmark: Ignore performance regressions, cargo test: Disable register_forget tests for now #34938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
def- wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feature-benchmark: Ignore performance regressions, cargo test: Disable register_forget tests for now #34938

def- wants to merge 1 commit into from

Conversation

@def-
Copy link
Contributor

@def- def- commented Feb 7, 2026

See https://github.com/MaterializeInc/database-issues/issues/10082

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@def- def- requested review from antiguru and bosconi February 7, 2026 20:48
@def- def- requested a review from aljoscha as a code owner February 8, 2026 06:36
@def- def- requested a review from bkirwi February 8, 2026 06:36
@def- def- changed the title feature-benchmark: Ignore performance regressions feature-benchmark: Ignore performance regressions, cargo test: Disable register_forget tests for now Feb 8, 2026
@def- def- enabled auto-merge (squash) February 8, 2026 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antiguru antiguru Awaiting requested review from antiguru

@bosconi bosconi Awaiting requested review from bosconi

@aljoscha aljoscha Awaiting requested review from aljoscha

@bkirwi bkirwi Awaiting requested review from bkirwi

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@def-