Remove BinaryFunc::RangeContainsElem in favor of typed variants#34950
Merged
antiguru merged 2 commits intoMaterializeInc:mainfrom Feb 9, 2026
Merged
Remove BinaryFunc::RangeContainsElem in favor of typed variants#34950antiguru merged 2 commits intoMaterializeInc:mainfrom
antiguru merged 2 commits intoMaterializeInc:mainfrom
Conversation
antiguru
force-pushed
the
binary_func_range_contains
branch
2 times, most recently
from
48674d7 to
177641b
Compare
ggevay
reviewed
Feb 9, 2026
Replace the generic RangeContainsElem { elem_type, rev } variant with
the existing typed sqlfunc variants (RangeContainsI32, RangeContainsDate,
etc.) that were already defined but not wired up as BinaryFunc enum
variants. The caller in src/sql/src/func.rs now dispatches to the
correct typed variant based on the element type.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>
antiguru
force-pushed
the
binary_func_range_contains
branch
from
5e1e972 to
33012e5
Compare
Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>
antiguru
force-pushed
the
binary_func_range_contains
branch
from
33012e5 to
47d3e62
Compare
ggevay
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RangeContainsElem { elem_type, rev }variant with the existing typed sqlfunc variants (RangeContainsI32,RangeContainsDate, etc.)#[sqlfunc]but not wired up asBinaryFuncenum variantssrc/sql/src/func.rsnow dispatches to the correct typed variant based on the element type🤖 Generated with Claude Code