Convert BinaryFunc::Normalize to use #[sqlfunc] macro#34952
Merged
antiguru merged 1 commit intoMaterializeInc:mainfrom Feb 9, 2026
Merged
Convert BinaryFunc::Normalize to use #[sqlfunc] macro#34952antiguru merged 1 commit intoMaterializeInc:mainfrom
antiguru merged 1 commit intoMaterializeInc:mainfrom
Conversation
antiguru
force-pushed
the
binary_func_normalize
branch
from
d05a8ac to
2897ad4
Compare
ggevay
approved these changes
Feb 9, 2026
antiguru
force-pushed
the
binary_func_normalize
branch
from
2897ad4 to
fbd8ef3
Compare
Convert the Normalize unit variant to use the standard #[sqlfunc] pattern with typed arguments instead of raw Datum values. Remove the old normalize_with_form helper from impls/string.rs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>
antiguru
force-pushed
the
binary_func_normalize
branch
from
fbd8ef3 to
513a858
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Normalizeunit variant to use the standard#[sqlfunc]patternNormalizestruct implementingEagerBinaryFuncwith typed arguments (&str,&str) instead of rawDatumvalues🤖 Generated with Claude Code