Split BinaryFunc::IsRegexpMatch into two sqlfunc variants #34953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the `IsRegexpMatch { case_insensitive: bool }` variant with
two separate sqlfunc variants: `IsRegexpMatchCaseSensitive` for `~`
and `IsRegexpMatchCaseInsensitive` for `~*`. This follows the same
pattern as `IsLikeMatchCaseSensitive`/`IsLikeMatchCaseInsensitive`.
Co-Authored-By: Claude Opus 4.6 <[email protected]>
Signed-off-by: Moritz Hoffmann <[email protected]>
antiguru
force-pushed
the
binary_func_is_regexp_match
branch
from
be87503 to
98857e1
Compare
ggevay
approved these changes
Feb 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
IsRegexpMatch { case_insensitive: bool }with two#[sqlfunc]variants:IsRegexpMatchCaseSensitive(~) andIsRegexpMatchCaseInsensitive(~*)IsLikeMatchCaseSensitive/IsLikeMatchCaseInsensitiveis_regexp_match_dynamichelper functionscalar.rsoptimization that lowers to unaryIsRegexpMatchwhen the pattern is a literal🤖 Generated with Claude Code