expr: convert TimezoneTimestamp and TimezoneTimestampTz to sqlfunc #34954
+179
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antiguru
force-pushed
the
binary_func_timezone_timestamp
branch
from
0d41cf6 to
cff0841
Compare
ggevay
approved these changes
Feb 9, 2026
…ttern Replace the unit BinaryFunc variants TimezoneTimestamp and TimezoneTimestampTz with tuple variants wrapping sqlfunc-generated structs TimezoneTimestampBinary and TimezoneTimestampTzBinary. This delegates all trait method implementations to the EagerBinaryFunc trait, reducing boilerplate and making the code consistent with other recently converted variants. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>
antiguru
force-pushed
the
binary_func_timezone_timestamp
branch
from
cff0841 to
5e21693
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the unit BinaryFunc variants TimezoneTimestamp and TimezoneTimestampTz with tuple variants wrapping sqlfunc-generated structs TimezoneTimestampBinary and TimezoneTimestampTzBinary.
This delegates all trait method implementations to the EagerBinaryFunc trait, reducing boilerplate and making the code consistent with other recently converted variants.
Summary
#[sqlfunc]functionstimezone_timestamp_binaryandtimezone_timestamp_tz_binarymatches!macro