expr: convert TimezoneInterval variants to sqlfunc #34955
Merged
+266
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antiguru
force-pushed
the
binary_func_timezone_interval
branch
from
7239d2a to
d99c83b
Compare
antiguru
force-pushed
the
binary_func_timezone_interval
branch
from
d99c83b to
1629a74
Compare
ggevay
approved these changes
Feb 9, 2026
ggevay
approved these changes
Feb 9, 2026
antiguru
force-pushed
the
binary_func_timezone_interval
branch
from
1629a74 to
7c271b1
Compare
Replace the unit BinaryFunc variants TimezoneIntervalTimestamp, TimezoneIntervalTimestampTz, and TimezoneIntervalTime with tuple variants wrapping sqlfunc-generated structs. Remove the old Datum-based helper functions which are no longer needed. This delegates all trait method implementations to the EagerBinaryFunc trait, reducing boilerplate and making the code consistent with other recently converted variants. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>
antiguru
force-pushed
the
binary_func_timezone_interval
branch
from
7c271b1 to
57039e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the unit BinaryFunc variants TimezoneIntervalTimestamp, TimezoneIntervalTimestampTz, and TimezoneIntervalTime with tuple variants wrapping sqlfunc-generated structs. Remove the old Datum-based helper functions which are no longer needed.
This delegates all trait method implementations to the EagerBinaryFunc trait, reducing boilerplate and making the code consistent with other recently converted variants.
Summary
#[sqlfunc]functionstimezone_interval_timestamp_binary,timezone_interval_timestamp_tz_binary, andtimezone_interval_time_binary