-
Notifications
You must be signed in to change notification settings - Fork 115
Add configurable resolution variables for JPEG and GIF generation #405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
more robust macro to check for windows
1.14.2 release
Co-authored-by: drbergman <[email protected]>
|
I have confirmed that this PR updates all
Some notes on this:
|
drbergman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have confirmed that this PR updates all make jpeg targets (n=20) that this should update. Details of search
- Match whole word and case:
jpeg: - files to include:
Makefile*(so we also get theMakefile-default - files to exclude:
unit_tests/, user_projects/, Makefile-backup
Some notes on this:
- The same results turn up when changing the search from
jpeg:togif:. - Not all Makefiles have these targets. A non-exhaustive search turned up the ODE sample and the boolean
cancer_invasionproject
Updated create_directory function to use C++17 filesystem library for improved directory creation on supported compilers.
|
@copilot why that now the dev branch is the base does the |
The
When I compare the actual file contents, they are identical (verified with To resolve this in the PR, you could either:
|
|
superseded by #408 (that was properly based on |
GIF and JPEG resolution currently depends on simulation domain size, and
make gifuses deprecatedmagick convertsyntax.Changes
Added configurable variables for ImageMagick density and resize parameters:
Simplified
jpegtarget from 8 lines with temporary files to single command:jpeg: magick mogrify -density $(MAGICK_DENSITY) -format jpg -resize $(MAGICK_RESIZE) $(OUTPUT)/s*.svgUpdated
giftarget to use modern syntax and add resolution control:gif: magick -density $(MAGICK_DENSITY) $(OUTPUT)/s*.svg -resize $(MAGICK_RESIZE) $(OUTPUT)/out.gifUsage
Override from command line for custom resolution:
Scope
Updated 20 Makefiles: main repository, Makefile-default, all 17 sample projects, and template_BM intracellular project.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.
Footnotes
When we reduce the domain size via the config file, we're noticed that the gifs generated with magick appear to have lower resolution. Is there a way to maintain or improve the resolution when using a smaller domain? The output SVGs seem to retain their quality. ↩
widthandheightattributes control the resolution. Those attributes are dependent on the simulation domain size, but are not equivalent due to padding for text / colorbar, so those could be good targets to put default sizes.</issue_description> ↩