[pull] androidx-main from androidx:androidx-main #792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a regression caused by aosp/3739808. When an alignment modifier from a different scope is used (e.g., using ColumnScope.align inside a Row), the alignment logic previously used the dimension corresponding to the modifier's axis (e.g., width for HorizontalAlignment) rather than the container's cross-axis dimension (e.g., height for a Row). This caused incorrect positioning offsets because the alignment calculation was using the item's main-axis size (width) to calculate alignment within the cross-axis space (height). Fixes: 477639546 Test: Added in RowColumnTest Change-Id: I0b01ab315847eb9c683517cfc8bbc5dde0b9802b
This change sets the opacity for the highlighter color palette when it is in use, but displays the colors without opacity in the palette itself. This ensures that the palette does not appear disabled when using dark mode. Bug: 476292532 Test: build and run on test device Change-Id: Ie23b640dfafb3af79815b13cb7cee92b1ea67138
Uses new `OnBitmapUpdatedListener` callback from `PdfView` to signal when page bitmaps are fetched or cleared. This allows `EditableDocumentViewModel` to track the bitmap availability for each page. When a bitmap is unavailable, the corresponding annotations for that page are hidden to prevent them from being displayed on a blank background. When the bitmap is fetched again, the annotations are redisplayed. Test: ./gradlew :pdf:pdf-ink:testReleaseUnitTest androidx.pdf.ink.fragment.EditableDocumentViewModelTest Bug: 439756145 Change-Id: Ie34d061e2c6f2cd8151c4d08ec5ec8f52a1afbf2
Add `isAttached` check when getting the `collapsedBounds`. Bug: 471730911 Test: manual Change-Id: I035457c06fc2088c59b4b779ff1cf466f0251959
…:runtime` and move tests. Test: unit test Bug: 440615454 Relnote: NA Change-Id: Ief5e936c8237de80ef1088d16f7995d09e28012b
…runtime:runtime` and move tests." into androidx-main
OverlayScene has a new onRemoved suspending callback that is invoked after a scene is popped but before it leaves composiiton. This allows exiting animations within the callback to complete before the overlay scene is removed from composition. NavDisplay internally stores a list of overlayScenes that are currently rendered on screen. It keeps track of popped scenes that are performing suspending work upon exit, and then finally removes the popped scene after the suspending work completes. Added a AnimatedBottomSheetSample in the Navigation3 demo app that shows bottom sheet slide down exit animation. Test: ./gradlew navigation3:navigation3-ui:androidConnectedCheck Bug: 440558061 Relnote: "OverlayScene has a new onRemoved suspending callback that is invoked after a scene is popped but before it leaves composiiton. This allows exiting animations within the callback to complete before the overlay scene is removed from composition." Change-Id: I29a728f2bc10ff4c0126ddf912907140a49676f9
LLB 10-bit restriction has been removed in aosp/3690172 Bug: 398697554 Test: N/A Change-Id: I122fcfffea39d35589160030cc1180e5c5c27e06
- Added a PdfEditMode interface - Enable form-filling by default in the EditablePdfViewerFragment journey of test-app Bug: 442767418 Test: EditablePdfViewerFragmentTestSuite Change-Id: I2df82e1c6c597ff85f27b9d3cb52e2cf92ef0612
…ved" into androidx-main
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )