Feed "label for plots" through as an "alias" in ESMValTool recipe#299
Conversation
# Conflicts: # CMEW/meta/rose-meta.conf
…alias' into 298_feed_model_label_through_as_alias
There was a problem hiding this comment.
This looks good. I run the tests and the metoffice workflow and all run correctly. I have not seen Acceptance Criteria in the #298 issue. I have seen comments on possible implementation, but as I understand at the moment this issue provides just the entries to 'alias' for both EVAL and REF. Is this sufficient?
I believe it is, as it needs to be combined with a separate PR on the ESMValTool repo to actually see any difference, but good to check with Alistair Sellar (@alistairsellar) or Emma Hogan (@ehogan). I'll ask for a second reviewer tomorrow. |
mo-nikosbaltas
left a comment
There was a problem hiding this comment.
I will wait for comments by Alistair Sellar (@alistairsellar) and Emma Hogan (@ehogan) and then I can approve.
There was a problem hiding this comment.
Looks good, thanks Naomi Parsons (@NParsonsMO)!
Yes, this meets the (unwritten :D ) acceptance criteria for the issue. The labels appear in the recipe, which means that when #302 is done, the labels appear in the plots.
I've suggested that we populate the labels in the default metadata. It's useful that the current commit demonstrates that when these are blank, it correctly populates them with the suite ID.
Also, copyrights on changed files will need updated to 2026.
Co-authored-by: Alistair Sellar <16133375+alistairsellar@users.noreply.github.com>
Co-authored-by: Alistair Sellar <16133375+alistairsellar@users.noreply.github.com>
Co-authored-by: Alistair Sellar <16133375+alistairsellar@users.noreply.github.com>
Closes #298 .
PR creation checklist for the developer
<issue_number>above ☝️ been replaced with the issue number?mainbeen selected as the base branch?<issue_number>_<short_description_of_feature>?good first issuelabel) been added to the PR?Climate Model Evaluation Workflow (CMEW)project been added to the PR?Definition of Done for the developer
docdirectory) related to the change been updated appropriately, including the Quick Start section?PR creation checklist for the reviewer
<issue_number>above ☝️ been replaced with the issue number?mainbeen selected as the base branch?<issue_number>_<short_description_of_feature>?good first issuelabel) been added to the PR?Climate Model Evaluation Workflow (CMEW)project been added to the PR?Definition of Done for the reviewer
docdirectory) related to the change been updated appropriately, including the Quick Start section? N/A