Skip to content

feat: add Stellar (XLM) support to keyring-api, keyring-internal-api, and eth-snap-keyring#483

Open
khanti42 wants to merge 19 commits intomainfrom
feat/add-stellar-pubnet-testnet
Open

feat: add Stellar (XLM) support to keyring-api, keyring-internal-api, and eth-snap-keyring#483
khanti42 wants to merge 19 commits intomainfrom
feat/add-stellar-pubnet-testnet

Conversation

@khanti42
Copy link
Copy Markdown

@khanti42 khanti42 commented Mar 25, 2026

Adds Stellar account support to the Accounts keyring stack, aligned with the existing TRX pattern and Stellar CAIP-2 (stellar:pubnet, stellar:testnet).

Changes

  • @metamask/keyring-api: New xlm module: XlmScope, XlmAccountType (xlm:eoa), XlmAddressStruct, XlmMethod, XlmAccountStruct, tests, and exports.
  • @metamask/keyring-internal-api: InternalXlmAccountStruct and internal account unions/maps.
  • @metamask/eth-snap-keyring: Account assertion for xlm:eoa, v1 migration default scopes for mainnet + testnet, and Snap keyring test updates.

Examples


Note

Medium Risk
Adds a new stellar:account type that flows through account validation and v1->v2 migration logic, which could affect account assertions/serialization for Snaps and internal account handling. Dependency bumps to @metamask/utils are low risk but broad in impact across packages.

Overview
Adds Stellar support across the keyring stack by introducing a new xlm module in @metamask/keyring-api (XlmScope, XlmAccountType, XlmMethod, XlmAccountStruct, and XlmAddressStruct validation) and exporting it, plus extending KeyringAccountType/struct enums to accept stellar:account.

Updates @metamask/keyring-internal-api to include InternalXlmAccountStruct and wire it into internal account unions/maps, and updates keyring-snap-bridge to assert stellar:account accounts and to default v1-migrated Stellar scopes to stellar:pubnet + stellar:testnet (with corresponding test coverage).

Bumps @metamask/utils from ^11.10.0 to ^11.11.0 across multiple packages and lockfile/changelogs.

Reviewed by Cursor Bugbot for commit a49dc9c. Bugbot is set up for automated code reviews on this repo. Configure here.

@stanleyyconsensys stanleyyconsensys marked this pull request as ready for review March 27, 2026 11:24
@stanleyyconsensys stanleyyconsensys requested a review from a team as a code owner March 27, 2026 11:24
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

@socket-security
Copy link
Copy Markdown

socket-security bot commented Apr 3, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​metamask/​utils@​11.10.0 ⏵ 11.11.098 +110094 +192 +2100

View full report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants