feat: add Stellar (XLM) support to keyring-api, keyring-internal-api, and eth-snap-keyring#483
Open
feat: add Stellar (XLM) support to keyring-api, keyring-internal-api, and eth-snap-keyring#483
Conversation
gantunesr
reviewed
Mar 31, 2026
gantunesr
reviewed
Mar 31, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Adds Stellar account support to the Accounts keyring stack, aligned with the existing TRX pattern and Stellar CAIP-2 (
stellar:pubnet,stellar:testnet).Changes
xlmmodule:XlmScope,XlmAccountType(xlm:eoa),XlmAddressStruct,XlmMethod,XlmAccountStruct, tests, and exports.InternalXlmAccountStructand internal account unions/maps.xlm:eoa, v1 migration default scopes for mainnet + testnet, and Snap keyring test updates.Examples
Note
Medium Risk
Adds a new
stellar:accounttype that flows through account validation and v1->v2 migration logic, which could affect account assertions/serialization for Snaps and internal account handling. Dependency bumps to@metamask/utilsare low risk but broad in impact across packages.Overview
Adds Stellar support across the keyring stack by introducing a new
xlmmodule in@metamask/keyring-api(XlmScope,XlmAccountType,XlmMethod,XlmAccountStruct, andXlmAddressStructvalidation) and exporting it, plus extendingKeyringAccountType/struct enums to acceptstellar:account.Updates
@metamask/keyring-internal-apito includeInternalXlmAccountStructand wire it into internal account unions/maps, and updateskeyring-snap-bridgeto assertstellar:accountaccounts and to default v1-migrated Stellar scopes tostellar:pubnet+stellar:testnet(with corresponding test coverage).Bumps
@metamask/utilsfrom^11.10.0to^11.11.0across multiple packages and lockfile/changelogs.Reviewed by Cursor Bugbot for commit a49dc9c. Bugbot is set up for automated code reviews on this repo. Configure here.