feat(social-controllers): add intent and category fields to Trade type#8410
Open
feat(social-controllers): add intent and category fields to Trade type#8410
Conversation
Add `intent` ("enter" | "exit") as the preferred alternative to the
semi-deprecated `direction` field, and `category` (optional) to
distinguish trade types (e.g. "receive" for airdrops/transfers).
TSA-371
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 4480a26. Configure here.
| @@ -30,8 +30,12 @@ export type SocialHandles = { | |||
| * A single trade within a position. | |||
| */ | |||
| export type Trade = { | |||
Contributor
There was a problem hiding this comment.
Instead of writing this type explicitly, we could infer it from the superstruct:
const TradeStruct = ...
export type Trade = Infer<typeof TradeStruct>
Comment on lines
+61
to
+62
| intent: string(), | ||
| category: optional(string()), |
Contributor
There was a problem hiding this comment.
Since intent and category both have a predetermined set of values, we could make the typing tighter:
intent: enums(['enter', 'exit']),
category: optional(enums([...]),
Contributor
Author
There was a problem hiding this comment.
let me ping them and ask, receive is the only category I'm aware of after discussing with them so far.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Add
intent("enter" | "exit") as the preferred alternative to the semi-deprecateddirectionfield, andcategory(optional) to distinguish trade types (e.g. "receive" for airdrops/transfers).TSA-371
References
Checklist
Note
Medium Risk
Adds a new required
Trade.intentfield and tightensSocialServiceresponse validation, which can break consumers or runtime parsing if upstream APIs don’t yet provide the new field. Scope is limited to social trade/position typing and schema checks.Overview
Updates the
Trademodel to include a new requiredintentfield (preferred over the semi-deprecateddirection) plus an optionalcategoryto distinguish trade types.Extends
SocialServicesuperstruct validation for position/trade payloads to requireintentand acceptcategory, and updates tests/changelog accordingly.Reviewed by Cursor Bugbot for commit 241032a. Bugbot is set up for automated code reviews on this repo. Configure here.