feat(snap-account-service): add SnapAccountService#8414
Open
feat(snap-account-service): add SnapAccountService#8414
SnapAccountService#8414Conversation
SnapAccountService
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
A new service where we will move the common logic of the current monolith
SnapKeyring.The idea is to be able to split this keyring into multiple ones and move the
KeyringEvents logic in this service.High-level architecture is the following:
For now, it's just an empty service, but we will move forward with more follow-up change as we are rewriting the existing
SnapKeyringto use the newKeyringV2.References
N/A
Checklist
Note
Low Risk
Low risk: this PR primarily adds a new package scaffold with an effectively no-op
SnapAccountServiceand wires it into monorepo configs, with no behavioral changes to existing packages.Overview
Adds a new
@metamask/snap-account-servicepackage, including an initialSnapAccountServiceclass (messenger-namespaced, no exposed actions/events yet) and a basicinit()placeholder plus a minimal Jest test.Wires the new package into repo metadata and build tooling: updates
README.mdpackage list/dependency graph, addsCODEOWNERS/teams.jsonownership entries, and includes the package in roottsconfigreferences andyarn.lockworkspace resolution.Reviewed by Cursor Bugbot for commit 1714c48. Bugbot is set up for automated code reviews on this repo. Configure here.