Skip to content

feat(snap-account-service): add SnapAccountService#8414

Open
ccharly wants to merge 8 commits intomainfrom
cc/feat/snap-account-service
Open

feat(snap-account-service): add SnapAccountService#8414
ccharly wants to merge 8 commits intomainfrom
cc/feat/snap-account-service

Conversation

@ccharly
Copy link
Copy Markdown
Contributor

@ccharly ccharly commented Apr 9, 2026

Explanation

A new service where we will move the common logic of the current monolith SnapKeyring.

The idea is to be able to split this keyring into multiple ones and move the KeyringEvents logic in this service.

High-level architecture is the following:

Screenshot 2026-04-09 at 14 49 23

For now, it's just an empty service, but we will move forward with more follow-up change as we are rewriting the existing SnapKeyring to use the new KeyringV2.

References

N/A

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Low Risk
Low risk: this PR primarily adds a new package scaffold with an effectively no-op SnapAccountService and wires it into monorepo configs, with no behavioral changes to existing packages.

Overview
Adds a new @metamask/snap-account-service package, including an initial SnapAccountService class (messenger-namespaced, no exposed actions/events yet) and a basic init() placeholder plus a minimal Jest test.

Wires the new package into repo metadata and build tooling: updates README.md package list/dependency graph, adds CODEOWNERS/teams.json ownership entries, and includes the package in root tsconfig references and yarn.lock workspace resolution.

Reviewed by Cursor Bugbot for commit 1714c48. Bugbot is set up for automated code reviews on this repo. Configure here.

@ccharly ccharly changed the title feat(snap-account-service): add SnapAccountService feat(snap-account-service): add SnapAccountService Apr 9, 2026
@ccharly ccharly marked this pull request as ready for review April 9, 2026 15:35
@ccharly ccharly requested a review from a team as a code owner April 9, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant