Skip to content

Add array sorting#32

Open
langhard wants to merge 5 commits into
MhdSyrwan:masterfrom
greenbananaCH:array_sorting
Open

Add array sorting#32
langhard wants to merge 5 commits into
MhdSyrwan:masterfrom
greenbananaCH:array_sorting

Conversation

@langhard

Copy link
Copy Markdown

It's not drag and drop (Issue #6), but a possibility to sort the arrays.

@MhdSyrwan

MhdSyrwan commented Mar 30, 2018

Copy link
Copy Markdown
Owner

Great, I will check this in the evening.
BTW, I think calling this feature sorting would be misleading. It should be called re-ordering, ordering .. etc.

Do you have any name suggestions ?

@langhard

Copy link
Copy Markdown
Author

Cool, thx!
I like „sorting“ but (re-)ordering is also ok.

@langhard

langhard commented Apr 3, 2018

Copy link
Copy Markdown
Author

Could you already have a look at the PR?

@MhdSyrwan

MhdSyrwan commented Apr 3, 2018

Copy link
Copy Markdown
Owner

I had a closer look at the code, but unfortunately haven't had the chance to run it.

Let's create a task list:

  • Rename feature name related variables, prop names and documentation.
  • Add some test cases to the test suite regarding this feature.
  • Make sure that the method you used Array.prototype.move exists in any current/future standard.

@langhard

Copy link
Copy Markdown
Author

Updated task list:

  • Rename feature name related variables, prop names and documentation.
  • Add some test cases to the test suite regarding this feature.
  • Make sure that the method you used Array.prototype.move exists in any current/future standard.

Question:
What do you mean with "Make sure that the method you used Array.prototype.move exists in any current/future standard." Can you help me with that?

@MhdSyrwan

MhdSyrwan commented Apr 11, 2018

Copy link
Copy Markdown
Owner

@langhard I've researched more about the move method. I was mistakenly thinking that it's an obsolete method of the JavaScript array prototype. And forgot about the fact that items is a FieldArray and not a normal JS array.

Currently our new todo list is:

  • Rename feature name related variables, prop names and documentation.
  • Add some test cases to the test suite regarding this feature.

Sorry for the inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants